Sema: Simplify adjustSelfTypeForMember() a little bit to avoid a cycle #34092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Sep 26, 2020
This check did not handle MemberRefExprs with an InOutExpr base, giving it inconsistent behavior: - With a class, we would diagnose self-assignment of computed properties - With a struct, accesses to computed properties would build a MemberRefExpr with an InOutExpr base, so self-assignments were *not* diagnosed. Let's tweak the check to consistently diagnose self-assignments to stored properties only, instead of the emergent behavior as described above.
We used to wrap the base expression in an InOutExpr when accessing a computed property. This was a vestigial remnant of differences in the SILGen code paths for stored vs computed property access. These days SILGen doesn't care and is perfectly happy to call getters and setters with an LValueType base as well. This allows us to remove the call to getAccessSemantics(), which for a 'didSet', had to kick off type checking of the body. Fixes <rdar://problem/69532933>.
Also remove the unused AccessSemantics parameter.
slavapestov
force-pushed
the
didset-access-semantics-cycle
branch
from
893036e to
71a281c
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to wrap the base expression in an InOutExpr when accessing a
computed property. This was a vestigial remnant of differences in the
SILGen code paths for stored vs computed property access.
These days SILGen doesn't care and is perfectly happy to call getters
and setters with an LValueType base as well.
This allows us to remove the call to getAccessSemantics(), which for
a 'didSet', had to kick off type checking of the body.
Fixes rdar://problem/69532933.