More ASTScope fixes in preparation for turning off parse-time lookup #34104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was read but never written to. I believe it was an artifact of the pre-ASTScope lookup logic.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
davidungar
approved these changes
Sep 28, 2020
Comment on lines
-717
to
-720
| if (resultsSizeBeforeLocalsPass == Results.size()) | ||
| out << "============== next pass ============\n"; | ||
| if (resultsSizeBeforeLocalsPass == ~0u) | ||
| out << "never tried locals\n\n"; |
There was a problem hiding this comment.
This and the block at 712 were useful for my debugging. But if you don't need them, it's fine by me.
There was a problem hiding this comment.
I deleted it because resultsSizeBeforeLocalsPass was never written to, so reading from it always produced the value ~0U. It appears that the only usage of this variable was in the DeclContext-based unqualified lookup that I deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.