[CSBindings] If hole originates from code completion token avoid "fixing" it #34118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new bindings It's possible that bindings would need to mutate constraint system e.g. by allocating new locators.
…oken as a potential hole If type variable is associated with a code completion token it's possible that it doesn't have enough contextual information to be resolved to anything, so let's add a hole type which originates from type variable associated with code completion expression to make this relationship explicit and avoid "fixing" problems rooted in fact that type variable is underconstrained due to code completion.
…ng it If the hole is originated from code completion expression let's not try to add a fix, anything connected to a code completion is allowed to be a hole because presence of a code completion token makes constraint system under-constrained due to e.g. lack of expressions on the right-hand side of the token, which are required for a regular type-check.
|
@swift-ci please smoke test |
nathawes
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the hole is originated from code completion expression
let's not try to add a fix, anything connected to a
code completion is allowed to be a hole because presence
of a code completion token makes constraint system
under-constrained due to e.g. lack of expressions on the
right-hand side of the token, which are required for a
regular type-check.