-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[ownership] Move ownership passed TempLValueOpt for the stdlib and add an ossa test case. #34119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ownership] Move ownership passed TempLValueOpt for the stdlib and add an ossa test case. #34119
Conversation
…d an ossa test case.
@swift-ci test |
@swift-ci smoke benchmark |
Not much to change in this pass since it is mainly dealing with projections/destroy_addr/copy_addr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import Builtin | ||
|
||
// CHECK-LABEL: sil [ossa] @test_enum_with_initialize | ||
// CHECK: bb0(%0 : $*Optional<Any>, %1 : $*Any): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : Add : after // CHECK-LABEL: sil [ossa] @test_enum_with_initialize
Same in all functions below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You are right! I should have fixed! I'll fix after the tests pass and then do a smoke test
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
Going to fix the nit in a post-commit review. |
No description provided.