Skip to content

[ownership] Move ownership passed TempLValueOpt for the stdlib and add an ossa test case. #34119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

No description provided.

@gottesmm gottesmm requested a review from meg-gupta September 29, 2020 21:37
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke benchmark

@gottesmm
Copy link
Contributor Author

Not much to change in this pass since it is mainly dealing with projections/destroy_addr/copy_addr

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import Builtin

// CHECK-LABEL: sil [ossa] @test_enum_with_initialize
// CHECK: bb0(%0 : $*Optional<Any>, %1 : $*Any):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : Add : after // CHECK-LABEL: sil [ossa] @test_enum_with_initialize
Same in all functions below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You are right! I should have fixed! I'll fix after the tests pass and then do a smoke test

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
FlattenListFlatMap 3524 5790 +64.3% 0.61x (?)
 
Improvement OLD NEW DELTA RATIO
UTF8Decode_InitFromData_ascii_as_ascii 656 600 -8.5% 1.09x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
NSError 260 208 -20.0% 1.25x (?)
SevenBoom 860 755 -12.2% 1.14x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
SevenBoom 1712 1904 +11.2% 0.90x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

@gottesmm
Copy link
Contributor Author

Going to fix the nit in a post-commit review.

@gottesmm gottesmm merged commit 327f4f8 into swiftlang:main Sep 30, 2020
@gottesmm gottesmm deleted the pr-3dbdc1ef99544b8d7483b31000e466a446562218 branch September 30, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants