Skip to content

ModuleInterface: refactor ModuleInterfaceChecker out of ModuleInterfaceLoader #34121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

ModuleInterface: refactor ModuleInterfaceChecker out of ModuleInterfaceLoader #34121

merged 1 commit into from
Oct 2, 2020

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Sep 30, 2020 •
edited
Loading

This refactoring allows us to drop ModuleInterfaceLoader when explicit modules are enabled. Before this change, the dependencies scanner needs the loader to be present to access functionalities like collecting prebuilt module candidates.

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from ce92a31 to add6f8c Compare September 30, 2020 18:08
@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from add6f8c to 63c283b Compare September 30, 2020 18:42
@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from 63c283b to 870f835 Compare September 30, 2020 21:00
@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

1 similar comment
@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from 870f835 to d31e31f Compare September 30, 2020 22:05
@nkcsgexi
Copy link
Contributor Author

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from d31e31f to c386fcb Compare October 1, 2020 00:04
@nkcsgexi nkcsgexi changed the title [WIP] ModuleInterface: refactor ModuleInterfaceChecker out of ModuleInterfaceLoader ModuleInterface: refactor ModuleInterfaceChecker out of ModuleInterfaceLoader Oct 1, 2020
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please smoke test

2 similar comments
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please clean test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - c386fcbd214342e70bcf04aacb31873b894413d6

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - c386fcbd214342e70bcf04aacb31873b894413d6

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi
ModuleInterface: refactor ModuleInterfaceChecker out of ModuleInterfa…
8ccee27 
…ceLoader

This refactoring allows us to drop ModuleInterfaceLoader when explicit modules
are enabled. Before this change, the dependencies scanner needs the loader to be
present to access functionalities like collecting prebuilt module candidates.
@nkcsgexi nkcsgexi force-pushed the refactor-module-interface-loader branch from c386fcb to 8ccee27 Compare October 1, 2020 17:31
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci Please clean test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2020

Build failed
Swift Test Linux Platform
Git Sha - 8ccee27

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Oct 1, 2020

swiftlang/llvm-project#1884
@swift-ci Please clean test Linux platform

@nkcsgexi nkcsgexi mentioned this pull request Oct 2, 2020
Merged
@nkcsgexi nkcsgexi merged commit a71e4fb into swiftlang:main Oct 2, 2020
@kastiglione kastiglione mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkcsgexi @swift-ci @harlanhaskins