[update_checkout] Improved validation failure diagnostic. #34124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an alias were defined for multiple schemes, the produced
diagnostic would only say that there was a collision, but did not
specify where that collision was. Here, the diagnostic is improved to
read
RuntimeError: Configuration file defines the alias ALIAS in both the
SCHEME_NAME_1 scheme and the SCHEME_NAME_2 scheme?!
|
@swift-ci Please Python Lint |
|
@swift-ci please smoke test |
shahmishal
approved these changes
Sep 30, 2020
AnthonyLatsis
added
the
update-checkout
nate-chandler
deleted the
update-checkout/better-config-validation-failure-diagnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an alias were defined for multiple schemes, the produced diagnostic would only say that there was a collision, but did not specify where that collision was. Here, the diagnostic is improved to read