Skip to content

AST: Fix assertions crash with try expressions (main branch cherry-pick) #34131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Sep 30, 2020

Look through try expressions inside open existential expression's sub expression in getUnwrappedCurryThunkExpr().

This cherry-picks #32458 to the 5.3 branch.

Resolves SR-12994.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov MaxDesiatov changed the title AST: Fix assertions crash with try expressions (main cherry-pick) AST: Fix assertions crash with try expressions (main branch cherry-pick) Sep 30, 2020
@MaxDesiatov MaxDesiatov marked this pull request as ready for review September 30, 2020 20:07
@MaxDesiatov MaxDesiatov requested a review from a team as a code owner September 30, 2020 20:07
Copy link
Collaborator

@theblixguy theblixguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akyrtzi akyrtzi requested a review from nathawes October 1, 2020 03:00
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants