[windows] XFAIL crash-in-user-code test in MSVC 2017 #34143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also swiftlang#33383 where this problem is better explained. MSVC doesn't seem to trigger the exception code when no frame pointers are generated. The only thing missing would be for interpreted code to have a more informative crash message. Add a new LLVM Lit feature with the value of the VisualStudioVersion environment variable (it seems to not change even for minor versions, so it is an easy way to figure out the 2017/2019 difference, even if updates are applied). Use the new feature in a XFAIL check in the test.
|
@swift-ci please test |
|
Windows is failing because the LLDB problem (swiftlang/llvm-project#1887 haven't made it yet to |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Nov 7, 2020
The test started working in the last week, for unknown reasons. Remove the XFAIL line, but keep the infra for detecting the MSVC version for the tests. It might be useful later. If the test starts failing again, and nobody has any idea why, the best path forward might be marking it as UNSUPPORTED.
drodriguez
added a commit
that referenced
this pull request
Nov 8, 2020
…test [windows] Partial revert #34143. Remove XFAIL.
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 8, 2020
* 'main' of github.com:apple/swift: [windows] Partial revert swiftlang#34143. Remove XFAIL.
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Nov 10, 2020
The test is very flaky. It works and stops working randomly for no apparent reason. To avoid future problems, and since VS2019 keeps working without these problems, mark the tests as unsupported to avoid the noise. See also swiftlang#34143 and swiftlang#34625.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #33383 where this problem is better explained.
MSVC doesn't seem to trigger the exception code when no frame pointers are generated. The only thing missing would be for interpreted code to have a more informative crash message.
Add a new LLVM Lit feature with the value of the VisualStudioVersion environment variable (it seems to not change even for minor versions, so it is an easy way to figure out the 2017/2019 difference, even if updates are applied).
Use the new feature in a XFAIL check in the test.