Remove Type Body Fingerprints Flags #34151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This infrastructure has more than proven itself. Drop the code paths and tests supporting the status quo.
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
In order for type body fingerprints to work, these declarations must always be included. Drop the ability to turn this off.
|
@swift-ci test |
|
Excellent! Can you file a radar for the code completion thing? |
|
Build failed |
davidungar
reviewed
Oct 1, 2020
| @@ -4587,7 +4592,7 @@ Parser::parseDeclList(SourceLoc LBLoc, SourceLoc &RBLoc, Diag<> ErrorDiag, | |||
| if (RBLoc.isInvalid()) | |||
| hadError = true; | |||
|
|
|||
| if (!Context.LangOpts.EnableTypeFingerprints) | |||
| if (L->isCodeCompletion()) | |||
There was a problem hiding this comment.
This looks suspicious, because the predicate on line 4559 is different. Should this one be the same?
There was a problem hiding this comment.
My guess is that previously code completion had EnableTypeFingerprints disabled, so this brings back the old behavior but only when performing code completion. I already suggested Robert file a radar to investigate this further in my review above.
|
@swift-ci test Linux |
|
rdar://69890297 |
|
⛵ |
CodaFi
added a commit
to CodaFi/swift
that referenced
this pull request
Oct 22, 2020
I removed the implementation in swiftlang#34151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the staging flags for type body fingerprints.