AccessPath: Look past class casts when finding the reference root. #34159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
force-pushed
the
opt-ref-root
branch
6 times, most recently
from
5d63774 to
67a6350
Compare
|
@swift-ci test |
eeckstein
approved these changes
Oct 20, 2020
include/swift/SIL/MemAccessUtils.h
Outdated
| @@ -1201,6 +1201,10 @@ SILBasicBlock::iterator removeBeginAccess(BeginAccessInst *beginAccess); | |||
|
|
|||
| namespace swift { | |||
|
|
|||
| /// Return true if \p value is a cast that preserves the identity and | |||
There was a problem hiding this comment.
typo: .. if \p svi is a...
For class storage AccessedStorage is now close to what some passes use for RC identity, but it still does not look past wrapping references in an Optional.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For class storage AccessedStorage is now close to what some passes use
for RC identity, but it still does not look past wrapping references
in an Optional.