Make Unicode.Scalar.Properties added after ICU 55 available on Linux #34182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests in |
|
@spevans I was under the impression https://github.com/apple/swift/pull/34182/files#diff-325b1cd0f86517c6f5ab1f886210ab70L85 would take care of this. If not, I'll take that up tomorrow! |
|
Oh sorry, you are correct, I mis-read the diff! |
|
@swift-ci test |
|
Will this break Windows? |
|
@compnerd What version of ICU does the windows port use? |
|
@spevans Windows is generally using 65+ (the current builds for main and 5.3 are using 67). |
|
Closing this PR as we ship our own Unicode data now that includes emoji support for all platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0211 added new properties to
Unicode.Scalar.Properties. Some of the properties added were never made available on Linux because they were not yet available in ICU 55 (the default on Ubuntu 16.04).Since then, Swift on Linux has been changed to ship with ICU 61, so this is no longer a problem. This PR makes the remaining properties from SE-0211 available on Linux.
See #19860 for when ICU was added & always built with Swift on Linux.