Revert "[PassManager] Update PassManager's function worklist for newly added SILFunctions" #34188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y added SILFunctions"
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test Linux Platform |
|
Hi @meg-gupta Bisection points to this commit as the cause of a crasher we're seeing in S4TF that looks like a miscompile. Is that expected based on bug that was fixed by #30710, which this reverts? |
texasmichelle
added a commit
that referenced
this pull request
Nov 3, 2020
Reverts the reversion in #34188. Bisection points to #34188 as the cause of a crasher that looks to be the result of a miscompile. Adding this back resolves the crasher. Details of the crash: The `DiscontiguousSliceSlicing` test in validation-test/StdlibUnittest/RangeSet.swift crashes in the `every()` function on line 15. When the contents of this function are replaced with a functional equivalent that uses different syntax, the crash resolves.
|
@dabrahams This PR changes the order in which functions are optimized, and that can expose bugs in existing optimizations. Is there a repro ? I can take a look |
|
@texasmichelle has one; I think she was planning to post it to bugs.swift.org. |
|
Filed SR-13820 with details. Thanks for looking into it @meg-gupta ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30710
For some programs which create large number of specialized functions each with deep call chains. This can cause redundant DFS leading to large compile times. Reverting this until we implement a better incremental DFS for updating the bottom up order of newly added functions.