SwiftRemoteMirror: Add reflection metadata version query API #3419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slavapestov Can you review? I can follow up with the IRGen change. |
| @@ -19,6 +19,9 @@ | |||
|
|
|||
| #include "swift/Basic/RelativePointer.h" | |||
|
|
|||
| const uint16_t SWIFT_REFLECTION_METADATA_VERSION_MAJOR = 1; | |||
There was a problem hiding this comment.
Perhaps we should just have a single version number. Do we expect to handle major number mismatches differently from minor?
There was a problem hiding this comment.
I was mostly just adding it for flexibility. It could probably be one number.
|
@swift-ci Please smoke test |
rdar://problem/27251582
|
@swift-ci Please smoke test |
Emit a 16-bit constant that tracks the version of the reflection metadata emitted into binaries. This can be used to cross-check what is supported by the SwiftRemoteMirror library with the new version API. rdar://problem/27251582
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a major/minor version API to the SwiftRemoteMirror library. These numbers will correspond to some constants emitted in Swift binaries.
rdar://problem/27251582