Skip to content

Copy sources from Differentiation before building #34193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Oct 5, 2020

This is needed since the generation of files from gyb templates gets
confused when trying to use files in parent directories.
Symlinks are likely not an option since they could not be available
under a Windows build environment

Take this chance to add the proper header to the file

Addresses rdar://69953208

edymtt added 2 commits October 5, 2020 10:01
This is needed since the generation of files from gyb templates gets
confused when trying to use files in parent directories.
Symlinks are likely not an option since they could not be available
under a Windows build environment

Addresses rdar://69953208
@edymtt edymtt requested review from compnerd, gottesmm and rxwei October 5, 2020 22:00
@edymtt
Copy link
Contributor Author

edymtt commented Oct 5, 2020

@swift-ci please smoke test

@edymtt edymtt requested a review from shahmishal October 5, 2020 22:02
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it makes more sense to just push this down to the same directory. Your current change wont work with incrementals as the copy will only occur once at configure time.

@edymtt
Copy link
Contributor Author

edymtt commented Oct 23, 2020

Turns out that I did not need to introduce this implementation of Differentiation in the first place.

Closing this PR and tracking removal in #34409

@edymtt edymtt closed this Oct 23, 2020
@edymtt edymtt deleted the copy-sources-for-differentiation-notgmath branch October 23, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants