Skip to content

[Sema] NFC: Move TypeChecker.h to include/swift/Sema #34194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Sema] NFC: Move TypeChecker.h to include/swift/Sema #34194

wants to merge 1 commit into from

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 5, 2020

In an effect to make Sema unit-testable, let's start by moving
TypeChecker.h to include/swift/Sema so it come be referenced
outside of lib/Sema.

@xedin
[Sema] NFC: Move TypeChecker.h to include/swift/Sema
de36be2 
In an effect to make Sema unit-testable, let's start by moving
`TypeChecker.h` to `include/swift/Sema` so it come be referenced
outside of `lib/Sema`.
@xedin xedin requested a review from CodaFi October 5, 2020 22:17
@xedin
Copy link
Contributor Author

xedin commented Oct 5, 2020

Working towards getting constraint system related headers into include/swift/Sema so I can write some unit tests for binding inference and other things...

@xedin
Copy link
Contributor Author

xedin commented Oct 5, 2020

@swift-ci please clean test

@CodaFi
Copy link
Contributor

CodaFi commented Oct 6, 2020

I would really prefer we make a new header here. We've been trying for so long to eliminate TypeChecker.h altogether by farming its responsibilities out to real components.

@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

@CodaFi I think we could do that separately right? I'm really working towards moving ConstraintSystem.h and related headers over to include/swift/Sema, this was just something I had to do to get there...

@CodaFi
Copy link
Contributor

CodaFi commented Oct 6, 2020

Can ConstraintSystem.h absorb the relevant parts of TypeChecker.h?

@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

@CodaFi I'll look into doing that and going to keep this PR open for now.

@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

Looks like I'd need to move both typeCheckExpression variants over to constraint system header together with ContextualTypePurpose and doesn't seem to be any other dependencies here expect that ConstraintSystem.h doesn't include everything it uses so I'd need to untangle that mess :/

@xedin xedin mentioned this pull request Oct 6, 2020
Merged
@xedin xedin closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi Awaiting requested review from CodaFi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xedin @CodaFi