Sema: Disallow usage of settable Self-returning storage requirements … #34214
+52
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we aim for a specialized diagnostic for such assignments right away instead? |
slavapestov
approved these changes
Oct 7, 2020
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility release |
…on existential base
AnthonyLatsis
force-pushed
the
coself-mut
branch
from
d18479a to
8f43d88
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please test source compatibility debug |
|
Looks like the source compat suite's deterministically acting up for some other reason :( |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on existential base
In the future we could refine this rule so that we could safely make use of the getter and disallow interaction with the setter.
Although #34005 landed just 2 weeks ago, we could still use settable subscripts before that, so this is a source breaking change.