ModuleInterface: rephrase remark message when acquiring lock file failed #34220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original remark message “could not acquire lock file for module interface” sounds too severe. It may confuse users that this is a serious issue. We should rephrase it to a less obtrusive one. rdar://70055223
|
@swift-ci please smoke test |
xymus
reviewed
Oct 7, 2020
| @@ -393,7 +393,7 @@ ERROR(error_creating_remark_serializer,none, | |||
| "error while creating remark serializer: '%0'", (StringRef)) | |||
|
|
|||
| REMARK(interface_file_lock_failure,none, | |||
| "could not acquire lock file for module interface '%0'", (StringRef)) | |||
| "building module interface without lock file", ()) | |||
There was a problem hiding this comment.
That's much less scary, I like it!
Would it be useful to say what is the drawback here, like "this may oversubscribe the CPU"? But I'm not sure if it would be reassuring knowing why me remark on lock files or bring more confusion tbh.
There was a problem hiding this comment.
yeah, I don't think this additional information offers much value to the users.
xymus
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original remark message “could not acquire lock file for module interface” sounds too severe.
It may confuse users that this is a serious issue. We should rephrase it to a less obtrusive one.
rdar://70055223