[Sema] Correct lvalue computation in buildStorageRef for synthesizing local accessors.
#34230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Oct 8, 2020
CodaFi
added a commit
to CodaFi/swift
that referenced
this pull request
Jul 6, 2021
AutoClosureExprs created by the constraint system used to be constructed with the decl context of the constraint system itself. This meant that autoclosures in expressions nested in closures would initially be parented onto any enclosing functions rather than the deepest closure context. When we ran capture analysis and lookup from inside of the body of these nascent values, we would fail to find declarations brought into scope by those parent closures. This is especially relevant when pre-typechecked code is involved since captures for those declarations will be forced before their bodies have been recontextualized. See issue swiftlang#34230 for why we need to force things so early. The attached test case demonstrates both bugs: The former a bogus lookup through the parent context that would incorrectly reject this otherwise well-formed code. The latter is a crash in SILGen when the capture computation would fail to note $0. Use the decl context of the solution application target, which is always going to be the deepest user-written closure expression available to us, and therefore the deepest scope that can introduce capturable variables. rdar://79248469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the local property wrapper implementation to address #34109 (comment)
The fix turned out to be pretty simple - the lvalue adjustment for the storage reference base simply needed to be moved earlier and slightly adjusted to account for cases where the base is not
self.