Skip to content

[ConstraintSystem] NFC: Move ConstraintSystem.h and related headers to include/swift/Sema #34235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2020
Merged

[ConstraintSystem] NFC: Move ConstraintSystem.h and related headers to include/swift/Sema #34235

merged 7 commits into from
Oct 9, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 8, 2020

Final step (first was #34206) in enabling unit testing for constraint system and related structures.

@xedin xedin requested a review from hborla October 8, 2020 07:37
@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

I have prepared a test fixture already, going to push that separately.

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - 67f3424c66219453a6aaa06daed0a2847c4f0a94

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - 67f3424c66219453a6aaa06daed0a2847c4f0a94

@xedin xedin force-pushed the cs-header-to-include branch from 67f3424 to 461eaff Compare October 8, 2020 17:46
@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

@swift-ci please clean test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2020

Build failed
Swift Test OS X Platform
Git Sha - 461eaff

@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - 461eaff

@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Oct 8, 2020

Build failed
Swift Test Linux Platform
Git Sha - 461eaff

@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Oct 8, 2020

🤞

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 461eaff

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 461eaff

@xedin
Copy link
Contributor Author

xedin commented Oct 9, 2020

@swift-ci please smoke test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Oct 9, 2020

Please test with following pull request:
swiftlang/swift-tools-support-core#142

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2020

Build failed
Swift Test Linux Platform
Git Sha - 461eaff

@xedin
Copy link
Contributor Author

xedin commented Oct 9, 2020

@swift-ci please test Linux platform

@xedin xedin merged commit 1b708ac into swiftlang:main Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @hborla