[concurrency] implement the 'unsafe' option for @actorIndependent #34260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
reviewed
Oct 10, 2020
include/swift/AST/Attr.def
Outdated
| OnClass | OnFunc | OnVar | OnSubscript | ConcurrencyOnly | | ||
| ABIStableToAdd | ABIStableToRemove | | ||
| APIStableToAdd | APIBreakingToRemove, | ||
| 104) |
kavon
changed the title
DougGregor
approved these changes
Oct 15, 2020
CodaFi
reviewed
Oct 15, 2020
CodaFi
reviewed
Oct 15, 2020
CodaFi
reviewed
Oct 15, 2020
CodaFi
reviewed
Oct 15, 2020
|
The code's looking good. One last request (sorry): could you do a rebase to clean up the history a little bit? |
|
Ok I cleaned it up into 3 commits. In future PR's I'll go with a rebasing strategy. |
|
@swift-ci smoke test |
atrick
reviewed
Oct 19, 2020
[broken] first impl of @actorIndependent in the type checker. [broken] fixed mistake in my parsing code wrt invalid source range [broken] found another spot where ActorIndependent needs custom handling [broken] incomplete set of @actorIndependent(unsafe) tests updates to ActorIndependentUnsafe [fixed] add FIXME plus simple handling of IndependentUnsafe context finished @actorIndependent(unsafe) regression tests added wip serialization / deserialization test focus test to just one actor class round-trip serialize/deserialize test for @actorIndependent serialize -> deserialize -> serialize -> compare to original most of doug's comments addressed robert's comments fix printing bug; add module printing to regression test [nfc] update comment for ActorIsolation::IndependentUnsafe
|
@swift-ci please smoke test |
|
Let's go ahead and merge, and we can tweak later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
@actorIndependent(unsafe), which disables static safety checks for accesses to actor-isolated storage. It is otherwise semantically the same as@actorIndependent(without the option) that is the 'safe' version.TODOs:
Fix missing detection of mutable state access from, Reported as SR-13735, but already fixed in@actorIndependentcomputed propertymain.@actorIndependent(unsafe)regression tests.