Skip to content

RCIdentityAnalysis: some refactoring to improve clarity. #34274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

eeckstein
Copy link
Contributor

NFC.

This is a follow-up of #34183

@eeckstein eeckstein requested a review from gottesmm October 12, 2020 15:29
@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test linux

@eeckstein eeckstein merged commit 4512717 into swiftlang:main Oct 13, 2020
@eeckstein eeckstein deleted the rc-identity branch October 13, 2020 08:01
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

/// type, like a metatype, to something which is retainable, like an AnyObject.
/// On some platforms such casts dynamically allocate a ref-counted box for the
/// metatype. Naturally that is the place where a new rc-identity begins.
/// Therefore such a cast is introducing a new rc identical object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants