Skip to content

[unittests] Add a fixture for Sema unit tests #34286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2020
Merged

[unittests] Add a fixture for Sema unit tests #34286

merged 6 commits into from
Oct 14, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 13, 2020

Adds a SemaTest fixture which handles all book-keeping related to setting up
environment and a simple literal binding inference test to demonstrate that
everything works correctly.

@xedin xedin requested review from artemcm and hborla October 13, 2020 00:25
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please smoke test

artemcm
artemcm approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@xedin xedin force-pushed the add-sema-unittest-fixture branch 2 times, most recently from 5b9a083 to 5161bd3 Compare October 13, 2020 01:10
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please clean smoke test

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please clean test Windows platform

@xedin xedin force-pushed the add-sema-unittest-fixture branch from 5161bd3 to 6e470f5 Compare October 13, 2020 07:12
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@compnerd Does Windows have <build>/lib/swift directory with built stdlib and other modules or artifacts are placed differently there? I'd hate it if I had to limit this tests to macOS only but I have to way to figure this out on my own...

xedin
xedin commented Oct 13, 2020
View reviewed changes
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test Windows platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test Windows platform

@xedin xedin force-pushed the add-sema-unittest-fixture branch from c6758d0 to fde1af7 Compare October 13, 2020 20:53
@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - fde1af7

@xedin
Copy link
Contributor Author

xedin commented Oct 13, 2020

@swift-ci please test macOS platform

@xedin xedin merged commit 6a19d37 into swiftlang:main Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

@artemcm artemcm artemcm approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xedin @swift-ci @compnerd @artemcm