Skip to content

Test the just-built libraries when building unittests on Darwin #34302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Test the just-built libraries when building unittests on Darwin #34302

merged 1 commit into from
Oct 15, 2020

Conversation

rjmccall
Copy link
Contributor

No description provided.

@rjmccall rjmccall requested a review from mikeash October 14, 2020 07:07
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@Azoy Azoy mentioned this pull request Oct 14, 2020
Closed
@Azoy
Copy link
Contributor

Azoy commented Oct 14, 2020

Does this also require changing SwiftRuntimeLongTests install name as well?

mikeash
mikeash approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rjmccall rjmccall force-pushed the runtime-unittests-install-name branch from da84e9e to 7e5c2c8 Compare October 15, 2020 00:47
@rjmccall
Copy link
Contributor Author

rjmccall commented Oct 15, 2020 •
edited
Loading

Does this also require changing SwiftRuntimeLongTests install name as well?

I've changed the patch to instead unconditionally rpath-ize all the Swift libraries of all unittests.

@mikeash Could you take another look?

@rjmccall rjmccall force-pushed the runtime-unittests-install-name branch from 7e5c2c8 to b0aa9ac Compare October 15, 2020 00:49
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b0aa9ac6675171fb3dac55289d072e3943d333ae

@rjmccall rjmccall force-pushed the runtime-unittests-install-name branch from b0aa9ac to beb39b3 Compare October 15, 2020 02:25
@rjmccall rjmccall changed the title Test the just-built runtime when building the runtime unittests on Darwin Test the just-built libraries when building unittests on Darwin Oct 15, 2020
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - beb39b370c5a80f01c4af6c6a7419428e7b54938

@rjmccall rjmccall force-pushed the runtime-unittests-install-name branch from beb39b3 to 1cc3a57 Compare October 15, 2020 05:26
@rjmccall
Copy link
Contributor Author

Everything passing but the Python linter, so switching to a smoke test.

@rjmccall
Copy link
Contributor Author

@swift-ci Please smoke test

@rjmccall rjmccall mentioned this pull request Oct 15, 2020
Merged
mikeash
mikeash reviewed Oct 15, 2020
View reviewed changes
mikeash
mikeash reviewed Oct 15, 2020
View reviewed changes
@rjmccall rjmccall merged commit 01672f5 into swiftlang:main Oct 15, 2020
@rjmccall rjmccall deleted the runtime-unittests-install-name branch October 15, 2020 17:11
@Azoy Azoy mentioned this pull request Oct 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjmccall @Azoy @swift-ci @mikeash