[5.3][Sema] Consider inherited platform unavailability to silence diagnostics #34323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
@swift-ci Please nominate |
|
Build failed |
DougGregor
approved these changes
Oct 15, 2020
|
@swift-ci please test macOS |
|
The macOS failure appears to be unrelated and tracked by rdar://66842937. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler reported a superfluous error on some uses of an unavailable type in unavailable declaration, which should be accepted. This affected only platforms like Mac Catalyst when the user declaration was marked unavailable on iOS and the unavailable type was defined in Objective-C. The fix makes the diagnostic consider the inherited platform unavailability on the user declaration to suppress the error.
Scope: This is affecting the Swift overlay for OSLog.
Risk: Low, this change can only show less errors.
Origination: Likely from the introduction of the diagnostic.
Resolves: rdar://68597591
Testing: Added tests to compare the difference in behavior between Swift and Objective-C declared types.
Cherry-pick of [Sema] Consider inherited platform unavailability to silence diagnostics #34087