Update swift-rpathize.py to work with Python 3.8 and Python 2.7 #34332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 2, str() is also a kind of bytes blob In Python 3, str() is a Unicode string that's unrelated
|
@swift-ci Python lint |
|
@swift-ci Please test |
rjmccall
approved these changes
Oct 16, 2020
Python-lint correctly warns about single-character variables that can be confused with numbers
|
Build failed |
|
macOS CI seems to be having problems apparently unrelated to this PR. I'll resubmit. |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please clean test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just need to explicitly convert the bytes blob into a real string before trying to pattern-match.
(In Python 2, str() and bytes are basically the same, so it's a lot more forgiving of such mixups.)