Skip to content

AST: Add a no-type-parameters early return to findProtocolSelfReferences #34342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2020
Merged

AST: Add a no-type-parameters early return to findProtocolSelfReferences #34342

merged 1 commit into from
Nov 1, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Oct 17, 2020 •
edited
Loading

I was going to add this to ProtocolDecl::findProtocolSelfReferences as well, but apparently, GenericFunctionType is purposely ignorant of its type parameters

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Oct 20, 2020

@swift-ci smoke test

@AnthonyLatsis
Copy link
Collaborator Author

ping @slavapestov

@CodaFi
Copy link
Contributor

CodaFi commented Nov 1, 2020

Let's just take this

⛵

@CodaFi CodaFi merged commit 16dec4c into swiftlang:main Nov 1, 2020
@AnthonyLatsis AnthonyLatsis deleted the 3-liner branch November 2, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @CodaFi