Skip to content

[ownership] Move OME past SILMem2Reg #34380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta
Copy link
Contributor Author

@swift-ci test source compatibility

@meg-gupta
Copy link
Contributor Author

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
FlattenListLoop 968 1378 +42.4% 0.70x (?)
 
Improvement OLD NEW DELTA RATIO
EqualSubstringSubstring 30 22 -26.7% 1.36x
LessSubstringSubstring 30 23 -23.3% 1.30x
EqualStringSubstring 30 23 -23.3% 1.30x (?)
EqualSubstringSubstringGenericEquatable 30 23 -23.3% 1.30x
EqualSubstringString 30 23 -23.3% 1.30x
LessSubstringSubstringGenericComparable 30 23 -23.3% 1.30x
StringComparison_longSharedPrefix 364 327 -10.2% 1.11x
SortStringsUnicode 2290 2060 -10.0% 1.11x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
EqualSubstringSubstring 30 22 -26.7% 1.36x (?)
EqualSubstringSubstringGenericEquatable 30 22 -26.7% 1.36x (?)
EqualSubstringString 30 22 -26.7% 1.36x (?)
LessSubstringSubstring 30 23 -23.3% 1.30x
EqualStringSubstring 30 23 -23.3% 1.30x (?)
LessSubstringSubstringGenericComparable 30 23 -23.3% 1.30x
SortStringsUnicode 2295 2050 -10.7% 1.12x (?)
StringComparison_longSharedPrefix 364 327 -10.2% 1.11x

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
EqualSubstringSubstringGenericEquatable 90 82 -8.9% 1.10x (?)
EqualSubstringSubstring 91 83 -8.8% 1.10x
EqualStringSubstring 90 83 -7.8% 1.08x (?)
EqualSubstringString 90 83 -7.8% 1.08x (?)
LessSubstringSubstringGenericComparable 90 83 -7.8% 1.08x (?)
SortStringsUnicode 3325 3090 -7.1% 1.08x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@meg-gupta meg-gupta merged commit 8145566 into swiftlang:main Oct 22, 2020
@meg-gupta meg-gupta deleted the moveomepastmem2reg branch July 9, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants