[Async CC] Test: Mark functions that call async functions async. #34402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
force-pushed
the
concurrency/irgen/tests-all-async
branch
2 times, most recently
from
c532dd0 to
22dbea9
Compare
…indings. Previously, NecessaryBindings used a SetVector to store the GenericRequirements that it accumulates. That was a problem for the layout of async contexts where it is possible for the same generic argument to be repeated. Meanwhile, that is correct for partial application forwarders where there is a single thunk for every partial apply and consequently the bindings can be packed in without duplication. Here, a SetVector is used only when the NecessaryBindings are for partial apply forwarders. When the NecessaryBindings are instead for async functions, a SmallVector is used.
Previously the execution tests for the async calling convention ignored the rule that callers of async functions must themselves be async. Failing to obey that rule prevented landing of the SIL verification change that enforces that rule. Here, the tests are modified to satisfy that rule so that the SIL verification change can be landed.
nate-chandler
force-pushed
the
concurrency/irgen/tests-all-async
branch
from
22dbea9 to
a963d0a
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unblock the SIL verification that async functions are called only from async functions, update the tests to meet this invariant. To enable this, in particular,
@mainhad to be marked@asyncuntilTask.runDetachedis available. To allow that, a couple of small workaround were commited in their own commit. Reverting that commit when possible is tracked by rdar://problem/70597390.This process revealed an issue with AsyncContextLayout's usage of NecessaryBindings. Specifically, if an async function happens to use the same generic parameter twice, space was only made in the layout for one usage. That can't work for async callees which actually have two distinct generic parameters since they will need to bind the two distinct generic parameters separately since in general they will not be the same type even though at a particular call site they happened to be the same. To address this, make NecessaryBindings use a vector rather than a set to collection generic requirements.