-
Notifications
You must be signed in to change notification settings - Fork 10.5k
CodeCompletion: Annotate archetypes, generic parameters and dependent… #34406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0552a22
to
4263d76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @nathawes Any concern?
@@ -1,4 +1,4 @@ | |||
import Foo | |||
import Foo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too - thanks for improving this!
@swift-ci please test |
Build failed |
Build failed |
4263d76
to
85c0304
Compare
@swift-ci please test |
Build failed |
Build failed |
85c0304
to
4ce7a2d
Compare
@swift-ci please test |
… members
The original goal was to have IDE annotate these in code completion descriptions, but the fixes to ASTPrinter ended up impacting the annotated output of some other SourceKit requests, likely and hopefully for the good.