Skip to content

CodeCompletion: Annotate archetypes, generic parameters and dependent… #34406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Oct 23, 2020

… members

The original goal was to have IDE annotate these in code completion descriptions, but the fixes to ASTPrinter ended up impacting the annotated output of some other SourceKit requests, likely and hopefully for the good.

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @nathawes Any concern?

@@ -1,4 +1,4 @@
import Foo
import Foo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change

Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too - thanks for improving this!

@nathawes
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4263d76329f81020df461543a8a6ccb40138a1a0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4263d76329f81020df461543a8a6ccb40138a1a0

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 85c0304b46f67b440966f95b56d55c628fe30bea

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 85c0304b46f67b440966f95b56d55c628fe30bea

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis merged commit 08612ff into swiftlang:main Oct 27, 2020
@AnthonyLatsis AnthonyLatsis deleted the ide-misc branch October 27, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants