[ConstraintSystem] Remove RValueAdjustment locator element
#34432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since unresolved members now introduce an implicit expression during pre-check, there is no need to add a separate r-value adjustment constraint to connect "tail" of the chain with chain result.
It was used for unresolved member and `.dynamicType` references as well as a couple of other places, but now unresolved member references no longer need that due to new implicit "chain result" AST node and other places could use more precise locators e.g. new `.dynamicType` locator or `sequence element` for `for in` loops.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Debug configuration is a UPASS, I have opened a PR on |
hborla
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was used for unresolved member and
.dynamicTypereferencesas well as a couple of other places, but now unresolved member
references no longer need that due to new implicit "chain result"
AST node and other places could use more precise locators
e.g. new
.dynamicTypelocator orsequence elementforfor ... inloops.