Skip to content

[build] Use llvm matching value for CMake policy CMP0077 #34449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

[build] Use llvm matching value for CMake policy CMP0077 #34449

merged 1 commit into from
Oct 27, 2020

Conversation

kastiglione
Copy link
Contributor

Set policy CMP0077 to NEW, which matches the value used by llvm. This prevents option() from overwriting an existing value. This also prevents a cmake warning from being printed.

compnerd
compnerd approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matching LLVM is always a good idea, and not printing warnings is a bonus ;-)

@kastiglione
Copy link
Contributor Author

@swift-ci smoke test

@kastiglione kastiglione merged commit 96c1e47 into main Oct 27, 2020
@kastiglione kastiglione deleted the build-Use-llvm-matching-value-for-CMake-policy-CMP0077 branch October 27, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kastiglione @compnerd