-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Async CC] Propagate runtime values. #34454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nate-chandler
merged 12 commits into
swiftlang:main
from
nate-chandler:concurrency/irgen/threading-values-through
Oct 28, 2020
Merged
[Async CC] Propagate runtime values. #34454
nate-chandler
merged 12 commits into
swiftlang:main
from
nate-chandler:concurrency/irgen/threading-values-through
Oct 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
adfd2d1
to
6e2da18
Compare
Added the llvm::StructType and a pointer to it.
38e0e33
to
6d08df2
Compare
Previously, a null task was always passed to swift_task_alloc/swift_task_dealloc. Now that the current task is available as one of the arguments to every async function, pass that value along to the runtime de/allocation functions.
When an async function is called from an async function, it stores its own context pointer into the callee's callerContext.
6d08df2
to
f3923e0
Compare
@swift-ci please test |
When an async function is called from an async function, the caller stores its own executor into the the callee's context in the ResumeParentExecutor field.
f3923e0
to
2ff6ea3
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #34453 .
This PR covers makes a few somewhat related changes:
Parent
ResumeParent
ResumeParentExecutor
swift_task_alloc
/swift_task_dealloc