Retain invalid decls when filtering using access path #34455
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Not sure why OSX failed. Linux also had an unrelated test failure. Windows (surprisingly) is the only platform that has just the relevant test failure: completion in the initializer of a top level decl shouldn't include the decl itself. There's a bug for including the decl when it's the first decl, but this change appears to regress that case to happening on every top level decl. This is probably worse than just missing the decl when it's invalid, so I'll look into fixing that first. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
bnbarham
force-pushed
the
benb/decl-filter-70704835
branch
from
1ec88cd to
26c3545
Compare
bnbarham
changed the title
|
I've updated the PR, adding another commit that remove the decl from the completion list when the completion is within its initializer. |
|
@swift-ci please test |
bnbarham
force-pushed
the
benb/decl-filter-70704835
branch
from
26c3545 to
00037b5
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
`::lookupVisibleDecls` had an inline consumer in order to remove "unusable" results. Refactor this method, moving the consumer (now `UsableFilteringDeclConsumer`) to allow its use when looking up top level module declarations. Also use the `AccessFilteringDeclConsumer` in preference to a condition in `addVarDecl`. Resolves rdar://56755598
Fixes missing declarations in the completions list due to their type being invalid. Resolves rdar://70704835
bnbarham
force-pushed
the
benb/decl-filter-70704835
branch
from
00037b5 to
4da190d
Compare
|
@swift-ci please test |
|
@compnerd the Windows builder ran out of space - is it missing some cleanup somewhere? |
|
@swift-ci Please smoke test Windows |
Fixes missing declarations in the completions list due to their type
being invalid.
Resolves rdar://70704835