Skip to content

[Runtime] Move ElementCapacity into the Elements allocation. #34464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Oct 27, 2020

This shrinks ConcurrentReadableHashMap a bit, which will be needed for adapting it for metadata caches.

@mikeash mikeash requested a review from tbkka October 27, 2020 19:39
@mikeash
Copy link
Contributor Author

mikeash commented Oct 27, 2020

@swift-ci please test

Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 66e6df2f4955aeba168b0df295a62343673368d8

This shrinks ConcurrentReadableHashMap a bit, which will be needed for adapting it for metadata caches.
@mikeash mikeash force-pushed the concurrentreadablehashmap-move-elementcapacity branch from 66e6df2 to 782fa27 Compare October 28, 2020 14:23
@mikeash
Copy link
Contributor Author

mikeash commented Oct 28, 2020

@swift-ci please smoke test

@mikeash
Copy link
Contributor Author

mikeash commented Oct 28, 2020

All tests passed except for symbol-visibility-linux.sh. Just pushed a fix for that.

@mikeash mikeash merged commit 7f2185d into swiftlang:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants