[Async CC] Add remaining fields to context. #34471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtered code for adding ResumeParent to the async layout through the new lambda.
Filtered code for adding ResumeParentExecutor to the async layout through the new lambda.
The following fields are now available when the function is a coroutine: - TaskContinuationFunction * __ptrauth(...) yieldToCaller? - TaskContinuationFunction * __ptrauth(...) resumeFromYield? - TaskContinuationFunction * __ptrauth(...) abortFromYield? - ExecutorRef calleeActorDuringYield? - YieldTypes yieldValues... These fields have yet to be filled in. The following field are now available when the function is NOT a coroutine (whereas previously they were always available): - ResultTypes directResults...
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fields either from the initial specification or from the declaration in Task.h had not yet been added to the layout of an async context. Here, those remaining field are here added. Specifically, the following fields are now part of the layout.
AsyncContextFlags FlagsTaskContinuationFunction * __ptrauth(...) yieldToCaller?TaskContinuationFunction * __ptrauth(...) resumeFromYield?TaskContinuationFunction * __ptrauth(...) abortFromYield?ExecutorRef calleeActorDuringYield?YieldTypes yieldValues...