Skip to content

[Concurrency] Task namespace, priority and always throwing Task.Handle.get #34475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2020

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Oct 28, 2020

rdar://70141994

This is a follow up after discussions on these pieces of the API;

Each commit should be self explanatory what the change is; the primary one being:

  • Task after all is only a namespace; we never get "a task" object in user land; all interaction with "my task" is via async context sensitive static functions
  • added a placeholder for priority -- not filled in as we're not entirely sure about its shape yet
  • Task.Handle.Failure was removed, as there is no meaningful way to constrain it because we have to allow CancellationError to be thrown, even if a referred to task is not throwing.

Follow up to: #34391

@ktoso ktoso requested review from rjmccall and DougGregor October 28, 2020 08:22
@ktoso
Copy link
Contributor Author

ktoso commented Oct 28, 2020

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Oct 28, 2020

@swift-ci please test

@ktoso
Copy link
Contributor Author

ktoso commented Oct 30, 2020

Merging this to unblock new PRs -- it's a simple follow up to the previous PR and addresses changes requested there and on offline discussions.

@ktoso ktoso merged commit 343f746 into swiftlang:main Oct 30, 2020
@ktoso ktoso deleted the wip-tasks-followup branch October 30, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant