[DiagnosticsQol] Modify diagnostic macro into single DIAG #34488
Conversation
lib/AST/DiagnosticEngine.cpp
Outdated
| StoredDiagnosticInfo(DiagnosticKind::Note, DiagnosticOptions::Options), | ||
| #define REMARK(ID, Options, Text, Signature) \ | ||
| StoredDiagnosticInfo(DiagnosticKind::Remark, DiagnosticOptions::Options), | ||
| #define DIAG(KIND, ID, Options, Text, Signature) \ |
There was a problem hiding this comment.
To shorten this definition we would need to capitalize all of the enum class DiagnosticKind values like the following:
enum class DiagnosticKind : uint8_t {
ERROR,
WARNING,
REMARK,
NOTE
};
@xedin WDYT?
There was a problem hiding this comment.
Which means, that this would require capitalization of these in other places as well right? I mean, wherever DiagnosticKind is referenced
There was a problem hiding this comment.
Naming style of the cases in enums has to stay consistent across repository. I think it's okay to just leave this as is.
There was a problem hiding this comment.
@xedin makes sense, I'll revert the change that I made for this then, and this will be the only case, where it will be left as is.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
Windows is failing due to CI issues, let's try one more time and if that land anyway. |
|
@swift-ci please test Windows platform |
This PR addresses SR-13774, which utilizes DefineDiagnosticMacros.h to shorten macro expansion (error, warning, note, remark) into DIAG.
Resolves SR-13774.