Skip to content

[async type lowering] Handle Void return from @objc async methods. #34503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

[async type lowering] Handle Void return from @objc async methods. #34503

merged 1 commit into from
Oct 30, 2020

Conversation

DougGregor
Copy link
Member

No description provided.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

jckarter
jckarter approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for now. I'm going to go over this again and try to generalize it properly for multiple returns in a tuple too. Thanks!

@DougGregor DougGregor merged commit 33452e1 into swiftlang:main Oct 30, 2020
@DougGregor DougGregor deleted the async-type-lower-void branch October 30, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @jckarter