Skip to content

[SR-13759] [Diag] Suggest inserting await when call is async #34509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

[SR-13759] [Diag] Suggest inserting await when call is async #34509

merged 1 commit into from
Nov 3, 2020

Conversation

maldahleh
Copy link
Contributor

@maldahleh maldahleh commented Oct 30, 2020 •
edited
Loading

When a call is async but is not marked with await, then we can suggest inserting await .

Resolves SR-13759.

@maldahleh maldahleh changed the title SR-13759: FixIt - Insert await when call is async [SR-13759] [Diag] Suggest FixIt to insert await when call is async Oct 30, 2020
@maldahleh maldahleh changed the title [SR-13759] [Diag] Suggest FixIt to insert await when call is async [SR-13759] [Diag] Suggest inserting await when call is async Oct 30, 2020
@maldahleh maldahleh force-pushed the sr-13759-insertAwaitOnAsyncFixIt branch from 9c0241a to 2930e09 Compare October 30, 2020 04:14
@harlanhaskins
Copy link
Contributor

@swift-ci please test

Thanks for your contribution, @maldahleh! This is going to help users a ton.

@maldahleh
Copy link
Contributor Author

@harlanhaskins Glad to contribute. Is there something I need to do to get the builds to run? I notice GitHub seems to still be waiting for tests.

@harlanhaskins
Copy link
Contributor

@swift-ci please test

@harlanhaskins
Copy link
Contributor

Hm, I'm surprised that last one didn't take. Right now, only members with a track record of contributions have access to invoke CI, so for now I or someone else in the project will need to manually invoke CI.

@harlanhaskins
Copy link
Contributor

@swift-ci please test

harlanhaskins
harlanhaskins approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@harlanhaskins harlanhaskins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Gonna quickly tag @kavon to take a look and make sure I didn't miss anything but I think this is good to go.

@kavon
Copy link
Member

kavon commented Nov 2, 2020

LGTM, though I can't currently merge it myself. @harlanhaskins

@harlanhaskins
Copy link
Contributor 

mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "dispatch_debug.exe". Access is denied.

Something happened with the Windows bot.

@swift-ci please smoke test Windows

@harlanhaskins harlanhaskins merged commit 15d566d into swiftlang:main Nov 3, 2020
@harlanhaskins
Copy link
Contributor

Thanks, @maldahleh!!

ainu-bot added a commit to google/swift that referenced this pull request Nov 3, 2020
@ainu-bot
Merge branch 'main' of github.com:apple/swift into tensorflow-stage
ac51c51 
* 'main' of github.com:apple/swift:
  SR-13759: FixIt - Insert await on async (swiftlang#34509)
@maldahleh maldahleh deleted the sr-13759-insertAwaitOnAsyncFixIt branch November 3, 2020 17:44
@swift-ci swift-ci mentioned this pull request Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavon kavon kavon approved these changes

@harlanhaskins harlanhaskins harlanhaskins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maldahleh @harlanhaskins @kavon