SILGen: Caller-side codegen for invoking foreign async functions #34525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Immediately before invoking the ObjC API, get the current continuation, capture it into a block to pass as the completion handler, and then await the continuation, whose resume/error successors serve as the semantic return/throw result of the call. This should complete the caller-side part of SILGen; the completion handler block implementation is however still only a stub.
…time. To manage code size in user binaries, we want to be able to implement common completion handler signatures in the Swift runtime once. Using a different mangling for these lets us add new ones without clobbering symbols in existing binaries.
jckarter
force-pushed
the
foreign-async-silgen
branch
from
7addae2 to
4b33f26
Compare
|
@swift-ci Please test |
DougGregor
approved these changes
Nov 4, 2020
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately before invoking the ObjC API, get the current continuation, capture it into a block to
pass as the completion handler, and then await the continuation, whose resume/error successors
serve as the semantic return/throw result of the call. This should complete the caller-side part
of SILGen; the completion handler block implementation is however still only a stub.