Skip to content

[cxx-interop] Bail if the type a reference type is wrapping is unkown. #34537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

zoecarver
Copy link
Contributor

If we can't find the type a reference type is wrapping (the pointee type), then don't import that type instead of crashing later.

If we can't find the type a reference type is wrapping (the pointee
type), then don't import that type instead of crashing later.
@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Nov 1, 2020
Copy link
Contributor

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zoe! :)

@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test and merge.

@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test Linux platform.

@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test Windows platform.

@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test Linux platform.

@zoecarver zoecarver merged commit db58c7e into swiftlang:main Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants