[CodeCompletion] Do not include decl in own (string interp) initializer #34548
Conversation
|
@swift-ci please test |
|
Just noticed I had left the types of the added tests as Int rather than String. Shouldn't matter but do you want me to fix that? |
|
Build failed |
The previous one should fix that case, but I can add it in this one. May as well fix the type while I'm at it as well. Thanks :) |
Strings are a single token, so the previous check would treat completions inside string interpolations as being outside of the initializer. Grab the end of the token from the Lexer, but wrap in a context check to avoid performing that for every declaration found in the lookup. Resolves rdar://70833348
Similar to 4cf7426 but for the case when the completion is in a default argument expression rather than initializer. Fixed to grab either the initializer or default argument if there is one.
bnbarham
force-pushed
the
completion-string-interp-init-70833348
branch
from
97d7e9d to
c3d1e34
Compare
|
Previous did not fix... it was only checking the initializer, not for a default argument. Added another commit to fix that one as well. Also enabled some disabled tests that should work now (have for a while I think). Let me know if you'd prefer it in a separate PR. |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
Strings are a single token, so the previous check would treat
completions inside string interpolations as being outside of the
initializer.
Grab the end of the token from the Lexer, but wrap in a context check to
avoid performing that for every declaration found in the lookup.
Resolves rdar://70833348