[cxx-interop] Support class templates containing typedefs. #34557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an assertion in "isOverAligned" caused class templates that contain and use typedefs.
|
Actually, could you please add header guards into the test header? We use them in all test headers (I hope :) |
|
@hlopko I'm happy to do it either way. I added header guards in some of my earlier patches but then I was asked not to. As I said, I don't really care. But we should try to be uniform on this, and I think the consensus is not to have them (for the reasons stated in the above link). |
|
Please take a look if this problem is fixed by #34538. |
|
@hlopko unfortunately, it doesn't look like it is. So I'm going to land this PR. |
|
@swift-ci please smoke test and merge. |
1 similar comment
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an assertion in "isOverAligned" caused by class templates that contain and use typedefs.