[sil-cse] Add CSE support for open_existential_ref #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
This method returns true if a given kind of instructions may have opened archetype operands. It does not mean that a concrete instruction instance necessarily has such operands.
Serialize SIL basic blocks in the RPOT order to make sure that instructions defining open archetypes are serialized before instructions using those opened archetypes.
swiftix
force-pushed
the
cse-of-open-existentials
branch
from
8609548 to
6956bd8
Compare
|
@swift-ci Please test |
| @@ -381,14 +390,29 @@ bool llvm::DenseMapInfo<SimpleValue>::isEqual(SimpleValue LHS, | |||
| if (LHS.isSentinel() || RHS.isSentinel()) | |||
| return LHSI == RHSI; | |||
|
|
|||
| if (isa<OpenExistentialRefInst>(LHSI) && isa<OpenExistentialRefInst>(RHSI)) { | |||
| // Consider the types of two open_existential_ref instructions to be equal, | |||
| // if the sets of protocols they conform to are equal. | |||
There was a problem hiding this comment.
…and their arguments are equal, no?
swiftix
force-pushed
the
cse-of-open-existentials
branch
from
6956bd8 to
cfdc943
Compare
|
@swift-ci Pleas test |
|
@swift-ci Please test |
|
The Linux test failure seems to be unrelated, because I see that other PRs had the same issue. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.