[TypeChecker] Do not attempt to skip typechecking for didSet #34569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
commented
Nov 4, 2020
bnbarham
force-pushed
the
do-not-skip-didset-typechecking
branch
from
5a6299b to
12683c1
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Build failed |
|
@swift-ci please test OS X platform |
15f8eb4 (see PR#26632) introduced refined didSet semantics where the `oldValue` parameter is skipped if it isn't used. This would perform typechecking, but later try to set the body to skipped and thus fire an assert. For now, do not attempt to skip typechecking of didSet accessors. Still skip outputting their SIL though.
bnbarham
force-pushed
the
do-not-skip-didset-typechecking
branch
from
12683c1 to
ea365d5
Compare
|
I fixed up the test so that it does the correct CHECK-NOT now :). |
|
@swift-ci please smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15f8eb4 (see PR#26632) introduced
refined didSet semantics where the
oldValueparameter is skipped if itisn't used. This would perform typechecking, but later try to set the
body to skipped and thus fire an assert.
For now, do not attempt to skip typechecking of didSet accessors. Still
skip outputting their SIL though.