Skip to content

[DNM] Workaround For More Modtimes Bugs #34576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 4, 2020

No description provided.

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 4, 2020

preset=buildbot,tools=RA,stdlib=RD
@swift-ci Please test with preset macOS

@@ -29,6 +29,7 @@
// RUN: touch %t/another-header.h
// RUN: cd %t && %target-swiftc_driver -c -incremental -emit-dependencies -emit-module -emit-module-path %t/C.swiftmodule -enable-experimental-cross-module-incremental-build -module-name C -I %t -output-file-map %t/C.json -working-directory %t -import-objc-header %t/bridging-header.h -Xfrontend -validate-tbd-against-ir=none -driver-show-incremental -driver-show-job-lifecycle C.swift 2>&1 | %FileCheck -check-prefix MODULE-C %s
// RUN: cd %t && %target-swiftc_driver -c -incremental -emit-dependencies -emit-module -emit-module-path %t/B.swiftmodule -enable-experimental-cross-module-incremental-build -module-name B -I %t -output-file-map %t/B.json -working-directory %t -driver-show-incremental -driver-show-job-lifecycle B.swift 2>&1 | %FileCheck -check-prefix MODULE-B %s
// RUN: touch %t/B.swiftmodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the module interface tests, we have a make-old.py script that sets the modtime to a fixed time in the past. That might be useful here as a source of determinism.

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 5, 2020

@swift-ci smoke test

@CodaFi CodaFi marked this pull request as ready for review November 5, 2020 20:18
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 5, 2020

@CodaFi CodaFi merged commit 704d5e6 into swiftlang:main Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants