[CodeCompletion] Add XFAIL to swift-ide-test #34579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Nov 4, 2020
Comment on lines
1194
to
1198
| bool failureExpected = false; | ||
| if (!Token.Xfail.empty()) { | ||
| failureExpected = true; | ||
| llvm::errs() << "Xfail: " << Token.Xfail << "\n"; | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't really matter but you could make this:
bool failureExpected = !Token.Xfail.empty();
if (failureExpected) {
llvm::errs() << ...;
}
In -batch-code-completion mode, add a token parameter 'xfail={reason}'.
When 'FileCheck' succeeds on the token, it is considered "unexpected
pass", and the test fails.
rdar://problem/71021285
rintaro
force-pushed
the
ide-test-batchcompletion-xfail
branch
from
f46a4a0 to
65f3133
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
-batch-code-completionmode, add a token parameterxfail={reason}. When (all) 'FileCheck' succeeds on the token, it is considered "unexpected pass", and the test fails.rdar://problem/71021285