[NFC] Construct AsyncContextLayout from module. #34585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, an IRGenFunction was being passed to the functions that construct an AsyncContextLayout. That was not actually necessary and prevented construction of the layout in contexts where no IRGenFunction was present. Here that requirement is eased to requiring an IRGenModule which is indeed required to construct an AsyncContextLayout.
|
@swift-ci please test |
nate-chandler
deleted the
concurrency/irgen/async-context-layout-uses-module-not-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an
IRGenFunctionwas being passed to the functions that construct anAsyncContextLayout. That was not actually necessary and prevented construction of the layout in contexts where noIRGenFunctionwas present. Here that requirement is eased to requiring anIRGenModulewhich is indeed required to construct anAsyncContextLayout.