[Concurrency] Nurseries are now Task.Groups
#34604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
Task.Groups
DougGregor
approved these changes
Nov 6, 2020
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-nurseries-are-groups
branch
from
0cc529c to
49c6ae3
Compare
|
Oh boy, silly typo slipped through; fixed. |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename as discussed in meeting @DougGregor @rjmccall
We decided to use
Task.Groupfor now rather than the confusingNurseryterm.I also considered calling the type
ScopedGroupbecause it is only to be used withTask.withGroup { ...and there may be a new one which we'd allow to store; and that one would be a normal Group or something similar perhaps. But we've not done that yet so not jumping ahead just yet. This will be better to work on once we have the basic infra working.rdar://70141994