Skip to content

[ownership] Now that we allow reborrows eliminate isForwardingSubValue it is dead. #34605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Nov 6, 2020

We only used this in one place that was not needed since we do reborrow verification instead of using the old model for borrowed phi arguments.

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 6, 2020

I am being extra careful and running full test with an assert along the only code path where we use this value here: #34606.

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 6, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Nov 6, 2020

@swift-ci test source compatibility

@gottesmm gottesmm merged commit b785a5f into swiftlang:main Nov 6, 2020
@gottesmm gottesmm deleted the pr-75f04ac2c27715c84382d9a9e4ca7c0337a3ce30 branch November 6, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants